Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Empty bl-select causes floating-ui to throw an error #825

Closed
1 task
ogunb opened this issue Apr 15, 2024 · 2 comments · Fixed by #826
Closed
1 task

[BUG]: Empty bl-select causes floating-ui to throw an error #825

ogunb opened this issue Apr 15, 2024 · 2 comments · Fixed by #826
Labels
bl-select Select Component bug Something isn't working released on @beta released

Comments

@ogunb
Copy link
Contributor

ogunb commented Apr 15, 2024

Issue description

Let's say you want to fetch options as user inputs search.

  1. Start with an empty bl-select.
  2. Click on bl-select.

The click action is going to log the error below and break popover functionality.
Uncaught TypeError: Cannot read properties of null (reading 'assignedSlot')

Reproduction: https://codepen.io/ogunb/pen/yLrqrZg

This is also preventing developers to slot things other than bl-select-option into the select component, such as an error message with a custom icon. Even though this may not something we want to support, it feels like a breaking change. Maybe we should go with a css solution instead.

#794
#803

Media & Screenshots

No response

Baklava Version

3.0.0-beta.5

Operating system

No response

Priority this issue should have

Medium (should be fixed soon)

Please review the checkboxes that are applicable.

  • This issue is directly related to React
Copy link

🎉 This issue has been resolved in version 3.0.0-beta.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ogunb ogunb added the bl-select Select Component label Apr 17, 2024
Copy link

github-actions bot commented May 2, 2024

🎉 This issue has been resolved in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bl-select Select Component bug Something isn't working released on @beta released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant