Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design System - Colors #91

Closed
Tracked by #64
muratcorlu opened this issue Apr 6, 2022 · 3 comments
Closed
Tracked by #64

Design System - Colors #91

muratcorlu opened this issue Apr 6, 2022 · 3 comments
Assignees
Labels
ADR-required An Architectural Design Record is needed for this issue documentation Improvements or additions to documentation released
Milestone

Comments

@muratcorlu
Copy link
Contributor

muratcorlu commented Apr 6, 2022

Design:

Figma Design Document

We'll implement this features on this issue;

  • Palette colors will be named semantically
  • Colors are conform with accessibility standards
  • Colors should calculate mathematically. For example here
@muratcorlu
Copy link
Contributor Author

muratcorlu commented Jan 4, 2023

During our investigations, together with @buseselvi and @fatihhayri we concluded with a plan:

  • Although HSL is known as not a perfect fit for creating a consistent, accessible color palette, because of the lack of browser support of some newer color functions in CSS (like LCH) we decided to use HSL anyway to have a more consistent (comparing to HEX/RGB colors) color coding in our color pallettes.
  • We'll update our current color pallette with a list of new colors those passing APCA standards.
  • We decided to use APCA over WCAG2.1 because current WCAG standard is already known as not consistent about color contrast in some different use cases. Altough APCA is not a standard yet, it's calcualtion takes the consideration of background/foreground colors and perceptual contrast calculation.
  • We'll create a PR with new color definitions with HSL and share some light value of the main color variants like key, hover, background.
  • We noticed that we already have some wrong usage of some similar colors (mostly secondary and content colors) while playing with new color palette. Those will be also fixed while implementing new pallette.
  • With a better documentation about theming Baklava, we'll focus on creating own color palettes for the projects that uses Baklava. Provided color palette will be a default, accessible palette but people will be free to use current or any other colors if they want.

We made a playground on codepen to test contrast values and their end results on Baklava components: https://codepen.io/muratcorlu/pen/MWXNNMp

Resources:

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@muratcorlu
Copy link
Contributor Author

We couldn't manage to finish A11Y requirements in our default color pallette but we'll come back to this topic in a separate (more specific) issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADR-required An Architectural Design Record is needed for this issue documentation Improvements or additions to documentation released
Projects
Archived in project
Development

No branches or pull requests

2 participants