cause 404 error if Loging happened from background thread.

[martinmani]

as this nuget uses HttpContextAccessor to get the http context properties, it cause 404 to next incoming request as the http-method becomes empty string.
please see aspnet/KestrelHttpServer#2591 for more details.

So instead of getting the properties at logging time it would be good idea to set the properties to LogContext in a middle ware so that HttpContextAccessor wont be accessed from a background thread.

[trenoncourt]

Hi,

Thanks for the catch.
Here is another package with middleware : https://github.com/trenoncourt/serilog-aspnetcore-middleware

[martinmani]

thank you but this is directly logging the http request details. Not enriching the logger or log context.
I was looking for enrich the SeriLog Context so that if any part of code will log message with the request details.