Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set a custom fold proportions for MultilabelStratifiedKFold (pass "r" to IterativeStratification) #13

Closed
lopuhin opened this issue Oct 26, 2020 · 3 comments

Comments

@lopuhin
Copy link

lopuhin commented Oct 26, 2020

For us it's useful to be able to set custom fold proportions when using MultilabelStratifiedKFold (essentially passing custom r to IterativeStratification). It's easy enough to extend outside of the lib (only _make_test_folds needs to be copied), but I wonder if such a feature could be useful in the library itself, what do you think?

And thanks for a great library!

@trent-b
Copy link
Owner

trent-b commented Nov 2, 2020

Thank you for the suggestion. Could you share a use case where it would be useful to set custom fold proportions (pass a custom r)? I am not opposed to the idea as long as there is a use case for it. If you would like, you could submit a Pull Request with the suggested change along with some test code that I could review and merge. Thanks!

@lopuhin
Copy link
Author

lopuhin commented Nov 2, 2020

Thank you! The use-case is that we want to distribute a part of the dataset across a fold subset (n-1 folds in our case), and then distribute the rest of the dataset across all folds - setting r on the second step allows to get folds of equal sizes. The reason why we want to do that is rather specific, that's why is could be quite a marginal use-case.

@trent-b
Copy link
Owner

trent-b commented Jul 29, 2022

Closing since there has not been additional activity.

@trent-b trent-b closed this as not planned Won't fix, can't repro, duplicate, stale Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants