Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with scikit-learn 1.0 in latest release #18

Closed
lunik1 opened this issue Sep 27, 2021 · 4 comments
Closed

Incompatibility with scikit-learn 1.0 in latest release #18

lunik1 opened this issue Sep 27, 2021 · 4 comments

Comments

@lunik1
Copy link

lunik1 commented Sep 27, 2021

As of scikit-learn 1.0 the deprecation warning fixed in 0a108bc has become a hard error. Could a new release be pushed to pypi in order to remain compatible with the latest scikit-learn?

For other users experiencing this issue (it will look something like

, in __init__
    super(MultilabelStratifiedShuffleSplit, self).__init__(
TypeError: __init__() takes from 1 to 2 positional arguments but 5 were given

^this) the workaround is to use the latest master of this package.

@CryptoSalamander
Copy link
Contributor

I fixed this issue and make PR.

@lunik1
Copy link
Author

lunik1 commented Oct 3, 2021

This issue is already fixed on master, but not in the latest release. I am asking for a new release so the fix can be in a released version.

@trent-b
Copy link
Owner

trent-b commented Oct 3, 2021

Thank you for bringing this to my attention. I will aim to create a new release and upload it to pypi.

@trent-b
Copy link
Owner

trent-b commented Oct 3, 2021

Version 0.1.7 with a fix to support scikit-learn 1.0 has been uploaded to pypi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants