Enable tlsOptions by upgrading ldapjs #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uprade ldapjs and add more options that can be passed to ldapjs client, most notably the tlsOptions which enables many features needed in order to be able to use ldaps with some LDAP servers.
New options, changed the line numbers to include those as well.
trentm
added a commit
that referenced
this pull request
Aug 26, 2013
Enable tlsOptions, timeout and connectTimeout options
|
Thanks! Sorry for the delay. Merged and released to npm as version 2.2.4. |
|
Whats the fix for #2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to use
ldaps://protocol to connect to the LDAP server in our organization. In order for the connection to succeed I need to be able to pass the CA certificate to tls module.Latest ldapjs
Clientsupports passing the tlsOptions to the tls module. This pull request upgrades ldapjs and addstlsOptions(as well astimeoutandconnectTimeout) options toLdapAuthconstructor.