Skip to content
This repository has been archived by the owner on May 30, 2022. It is now read-only.

Remove the discovery TTL consul health checks #208

Closed
stefanotorresi opened this issue Sep 1, 2021 · 3 comments · Fixed by #240
Closed

Remove the discovery TTL consul health checks #208

stefanotorresi opened this issue Sep 1, 2021 · 3 comments · Fixed by #240
Assignees
Labels
removal Removed functionality or dead code

Comments

@stefanotorresi
Copy link
Member

stefanotorresi commented Sep 1, 2021

We are misusing the Consul Health Check functionality to register a bunch of TTL checks which are not actually needed.

We can supersede these with a single trento-agent health check reporting the status of the agent itself (instead of the result of the HA Configuration Checks, which is going to be run by the Runner component instead).

Related to #89

@fabriziosestito
Copy link
Member

@stefanotorresi what should the Trento Health check depend on?

@stefanotorresi
Copy link
Member Author

@stefanotorresi what should the Trento Health check depend on?

Well, my idea would be that if any of the discovery loops fails, than this single check fails with some output about the specific error that occurred.
IOW I would like all the Consul health checks that we currently have for the discovery loops consolidated under a single one.

That said, if you have other ideas on how to self-check the Trento Agent, I'm all ears!

@fabriziosestito
Copy link
Member

fabriziosestito commented Sep 14, 2021

@stefanotorresi I have a PR ready for this, just holding it after the runner branch merge, i basically did what you just described but changed a little bit when the discoveries return errors (e.g. no error if nothing is discovered, just a negative result, which is displayed in the check result note)

@stefanotorresi stefanotorresi added removal Removed functionality or dead code and removed enhancement Improvement of existing features labels Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
removal Removed functionality or dead code
Development

Successfully merging a pull request may close this issue.

2 participants