Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion is not done on category #93

Open
mkathu opened this issue Oct 29, 2021 · 3 comments
Open

Assertion is not done on category #93

mkathu opened this issue Oct 29, 2021 · 3 comments

Comments

@mkathu
Copy link

mkathu commented Oct 29, 2021

I am using lighthouse ci github action of the latest version. My goal is to assert the following:

  1. Metrics
  2. Category (Performance)

I have configured the budget.json(desktop) and mob-budget.json(mobile) for validation of metrics and also I have separate config file for dekstop and mobile.

Below is budget.json
image

Below is the desktop config file:
image

Below is mob-budget.json
image

Below is the mobile config file
image

Below is the workflow using above mentioned files:
image

Expectation:
The lighthouse scan should be done for all pages mentioned in urls and it should asserted for metrics and categories for specified values.

Observed:
Only metrics is getting asserted and not category.

Link of one of the execution: https://github.com/mkathu/ul-witelabel-visual-test/runs/4042090535?check_suite_focus=true

Sharing the report of one of the page which does not match the configured performance value of 0.9 for desktop, but not getting asserted.
image

Any pointers would be greatly appreciated in making this work.

@mkathu
Copy link
Author

mkathu commented Nov 2, 2021

any update?

@mkathu
Copy link
Author

mkathu commented Dec 3, 2021

GoogleChrome/lighthouse-ci#731 (comment)

Any updated on this. I have also asked the same question in lighthouse ci GitHub.

@earlman
Copy link

earlman commented Feb 7, 2022

also having this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants