add unavailable dates feature #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarescrisan
changed the title
tresko
requested changes
Dec 22, 2019
| @@ -266,6 +268,7 @@ function Datepicker( | |||
| scrollTopToMonthGrid() | |||
| } | |||
|
|
|||
| console.log('BLOCKED ARRAY', unavailableDates) | |||
| @@ -321,6 +325,8 @@ function Day({day, date}: DayProps) { | |||
| [dayProps.isSelected, dayProps.isSelectedStartOrEnd, theme, dayProps.isWithinHoverRange], | |||
| ) | |||
|
|
|||
| console.log('DAY', day) | |||
| @@ -76,6 +78,7 @@ function App({ | |||
| } | |||
| } | |||
|
|
|||
| console.log('APP BLOCK', unavailableDates) | |||
packages/hooks/src/useDay/useDay.ts
Outdated
|
|
||
| function isInUnavailableDates(unavailableDates: Date[], date: Date) { | ||
| let isBlocked = false | ||
| unavailableDates.forEach(_date => { |
There was a problem hiding this comment.
Use reduce function instead forEach
packages/hooks/src/useDay/useDay.ts
Outdated
| @@ -13,6 +14,7 @@ interface UseDayProps { | |||
| onDateSelect(date: Date): void | |||
| onDateHover(date: Date): void | |||
| dayRef: React.RefObject<HTMLButtonElement> | |||
| unavailableDates: Date[] | |||
There was a problem hiding this comment.
This prop should be optional.
rarescrisan
force-pushed
the
@rarescrisan/add-unavailable-dates
branch
from
c8a31fc
to
87da71e
Compare
chore: add unavailableDates to useDate tests fix: fix comments chore: build chore: clean up
rarescrisan
force-pushed
the
@rarescrisan/add-unavailable-dates
branch
from
87da71e
to
dee83ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
unavailableDatesprop to context that allows a consumer to supply an array of dates that can be marked as unavailable.work was mostly introduced here:
packages/styled/src/components/Day/Day.tsx
packages/hooks/src/useDay/useDay.ts
packages/styled/src/context/datepickerContext.ts