Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mission badges #40

Merged
merged 2 commits into from Mar 11, 2022
Merged

add mission badges #40

merged 2 commits into from Mar 11, 2022

Conversation

Kandy-Peter
Copy link
Collaborator

In this pull request, I added the following functionalities

  • Missions that the user has joined already shows a badge "Active Member" instead of the default "NOT A MEMBER"
  • Button "Leave Mission" instead of the "Join Mission" button (as per design).

Copy link
Owner

@tresorsawasawa tresorsawasawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED 🟢 ✔️ ✔️ ✔️

Hi @Kandy-Peter
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉 👏 👏 💯

nodding-yes

To highlight 🍾

  • All linters are passing ✔️
  • Good commit history ✔️
  • Good PR description ✔️

Optional suggestions

  • Kindly Check the comments under the review._
    Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


_As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Kandy-Peter Kandy-Peter merged commit edce197 into development Mar 11, 2022
@Kandy-Peter Kandy-Peter deleted the mission-badges branch March 11, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants