Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning of python packages #120

Closed
scemama opened this issue May 12, 2023 · 2 comments
Closed

Versioning of python packages #120

scemama opened this issue May 12, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@scemama
Copy link
Member

scemama commented May 12, 2023

Please do not forget to update the Python API version when you change it in configure/CMakeLists

I really think that having two different version numbers for C/Fortran and Python is extremely confusing. If we tell users to get version 2.3.2 of the library, they will automatically do pip install trexio-2.3.2 and will get it wrong. It adds an extra layer of complexity.

As the Python package is distributed with the C library in a single repo, I think we should really have a common version number.

@scemama scemama added the enhancement New feature or request label May 12, 2023
@q-posev
Copy link
Member

q-posev commented May 12, 2023

I am sure that most of the time the users do pip install trexio without pinning the version :-)

The motivation to have them different was to allow patches in the Python API which do not affect C/Fortran. For example, recent bug with the loss of precision when reading float numbers was fixed purely on the Python side and this was reflected in the bump of Python patch version, without touching the C library. For me personally it would be more confusing to see a change in a C library version only because of the Python API.

You can sync both C and Python API versions if you want.

@scemama scemama closed this as completed May 12, 2023
@scemama
Copy link
Member Author

scemama commented May 12, 2023

I will do it from version 2.4.0 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants