Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor jumps to the end whenever the column name is edited and not at the end #424

Closed
GuybrushX opened this issue May 11, 2023 · 9 comments
Labels
bug Something isn't working

Comments

@GuybrushX
Copy link

Describe the bug

The cursor always jumps to the end of the column name when it is edited.

Steps to reproduce

Try to rename a column and place the cursor anywhere but not at the end. For example try to change the name like that:
Before: My Column
After: This is My New Column

As soon as you place the cursor at the beginning or anywhere else the cursor jumps to the end.

Workarounds:

  1. Write the new name somewhere else and paste it
  2. Delete the column name and write it again from scratch

Expected behavior

No jumping cursor.

Are you using the mobile app?

No

Obsidian debug info

SYSTEM INFO:
Obsidian version: v1.2.7
Installer version: v1.2.7
Operating system: Windows 10 Pro 10.0.22621 <- this seems to be an Obsidian bug, it's Win 11 Pro
Login status: not logged in
Insider build toggle: off
Live preview: on
Legacy editor: off
Base theme: dark
Community theme: none
Snippets enabled: 0
Restricted mode: off
Plugins installed: 10
Plugins enabled: 10
1: Obsidian Git v2.19.1
2: Calendar v1.5.10
3: Tasks v3.5.0
4: Dataview v0.5.55
5: Excalidraw v1.8.26
6: ExcaliBrain v0.1.13
7: Kanban v1.5.3
8: Natural Language Dates v0.6.1
9: Advanced Tables v0.18.1
10: Notion-Like Tables v6.8.2

RECOMMENDATIONS:
Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.

Relevant log output

Shortcut doesn't work?
@GuybrushX GuybrushX added the bug Something isn't working label May 11, 2023
@decaf-dev
Copy link
Owner

@GuybrushX Thanks for finding this. I will push out the fix shortly

@decaf-dev decaf-dev mentioned this issue May 16, 2023
@decaf-dev
Copy link
Owner

@GuybrushX Fixed in 6.9.0

@GuybrushX
Copy link
Author

@trey-wallis Thanks for the fast fix - unfortunately it doesn't work (anymore?). I'm using 6.9.1 already, didn't try 6.9.0. Behavior seems like before -> cursor is jumping to the end on each key press.

ESC key should also cancel and revert editing - that's another small issue but if you're on it maybe it's easy as well.

@decaf-dev
Copy link
Owner

decaf-dev commented May 17, 2023

@GuybrushX Which cell types is this happening for? I don't have any issues on my end. Could you try disabling the Advanced Tables plugin?

@decaf-dev decaf-dev reopened this May 17, 2023
@GuybrushX
Copy link
Author

I've checked Text, Checkbox, Number, all the same issue.

@decaf-dev
Copy link
Owner

@GuybrushX Could you record a video and post it here?

@decaf-dev
Copy link
Owner

@GuybrushX "ESC key should also cancel and revert editing - that's another small issue but if you're on it maybe it's easy as well." This is not how Notion currently works, I could add that as a feature though it if seems useful.

@decaf-dev
Copy link
Owner

decaf-dev commented May 19, 2023

@GuybrushX I apologize, I seem to have misread the input for this issue. I fixed this issue for all cell inputs but not the column name input. I will push out a fix shortly

@decaf-dev decaf-dev mentioned this issue May 19, 2023
decaf-dev added a commit that referenced this issue May 19, 2023
* fix: prevent Obsidian events from firing on swipe

* fix: hide tag overflow when wrap-overflow is on

* fix: fixes #424

* fix: fixes #387

* Delete cell content on backspace (#443)

* feat: add command for removing cell ids from mutiple tags at once

* feat: add #403

* Prevent undo redo as menu key (#444)

* refactor: simplify code

* fix: prevent menu from opening when undo/redo is pressed

* fix: fixes #434 (#446)

* Red Graphite theme (#449)

* fix: [WIP] fixes #435

* fix: stop window flash when a menu opens and is shifted into view

* fix: rerender view on css change (theme or color scheme)

* fix: save on first render

* chore: bump version
@decaf-dev
Copy link
Owner

@GuybrushX Fixed in 6.9.3

decaf-dev added a commit that referenced this issue Jul 7, 2023
decaf-dev added a commit that referenced this issue Jul 7, 2023
decaf-dev added a commit that referenced this issue Jul 7, 2023
* fix: prevent Obsidian events from firing on swipe

* fix: hide tag overflow when wrap-overflow is on

* fix: fixes #424

* fix: fixes #387

* Delete cell content on backspace (#443)

* feat: add command for removing cell ids from mutiple tags at once

* feat: add #403

* Prevent undo redo as menu key (#444)

* refactor: simplify code

* fix: prevent menu from opening when undo/redo is pressed

* fix: fixes #434 (#446)

* Red Graphite theme (#449)

* fix: [WIP] fixes #435

* fix: stop window flash when a menu opens and is shifted into view

* fix: rerender view on css change (theme or color scheme)

* fix: save on first render

* chore: bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants