Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to drag and drop enteries beyond the 1st one #460

Closed
Hexara7777 opened this issue May 22, 2023 · 9 comments
Closed

Unable to drag and drop enteries beyond the 1st one #460

Hexara7777 opened this issue May 22, 2023 · 9 comments
Labels
bug Something isn't working

Comments

@Hexara7777
Copy link

Hexara7777 commented May 22, 2023

Describe the bug

When I create a new table and try to drag and drop an entry, it works, draggin it or any other entry again doesn't work, I have to switch to another note/table/file and come back to it in order to be working again.

Steps to reproduce

  1. Create a table
  2. Add multiple columns
  3. Add multiple rows
  4. Set the first column to date type
  5. Create random date entries in the first column
  6. Drag and drop any entry in the first column
  7. Try to drag and drop any entry again, it won't work
  8. Switch to another table/note/file and then come back, it will work again
    Animation

Expected behavior

To be able to drag and drop beyond the 1st drag

Are you using the mobile app?

No

Obsidian debug info

SYSTEM INFO:
Obsidian version: v1.2.8
Installer version: v1.2.8
Operating system: Windows 10 Pro 10.0.19045
Login status: not logged in
Insider build toggle: off
Live preview: on
Legacy editor: off
Base theme: light
Community theme: none
Snippets enabled: 0
Restricted mode: off
Plugins installed: 5
Plugins enabled: 5
1: Dynamic RTL v0.2.12
2: Advanced Tables v0.18.1
3: Calendar v1.5.10
4: Kanban v1.5.3
5: Notion-Like Tables v6.9.3

RECOMMENDATIONS:
Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.

Relevant log output

Ctrl-Alt-I Doesn't work
@Hexara7777 Hexara7777 added the bug Something isn't working label May 22, 2023
@decaf-dev
Copy link
Owner

@SaifEl-Deen Thanks for your bug report. I will check this out soon. What were you trying to accomplish with Ctrl-Alt-I? Currently redo is not implemented for drag and drop. See: #454

@Hexara7777
Copy link
Author

Hexara7777 commented May 22, 2023

@trey-wallis You're welcome! Well, the bug report template asked me about something like a log or so, and it told me to press that shortcut to get that log.

image

@decaf-dev
Copy link
Owner

decaf-dev commented May 22, 2023

Ah. My apologies. That command opens the console on Mac. It appears I got the Windows command wrong. Try Ctrl + Shift + I

@Hexara7777
Copy link
Author

No problems :D
I don't know where to look for that log, it opens a menu just like Google Chrome Inspect menu
I updated the first post with a gif, it may help.

@decaf-dev
Copy link
Owner

decaf-dev commented May 26, 2023

@SaifEl-Deen Thanks for the gif image, it made this issue very easy to debug.

So the dragging system isn't broken. The row will show that it's draggable anywhere but in reality it's only draggable when clicking on the drag button.

The way that Notion handles dragging, and the way that I intend to handle draggle for now, is that you can only drag rows by using the drag button. This is because I may want to implement other dragging abilities within the table itself. See: #467

I do recognize though that there's an accessibility issue with the drag button being on the far right of the row. If a user has many columns, they will need to scroll to the right to be able to reorder their rows. I will change this so that the drag button is on the left of the row, for easier accessibility.

I may implement row reorder by dragging on any part of a row in the near future, but I need to figure out if I can do other drag operations on the row without that interfering.

@FeralFlora
Copy link

The issue is rather that that I made the row UI change to be draggable, when in reality it isn't, only the icon is. I have fixed this.

Thanks for the clarification! I will see how I fare with this in mind 👍

@Hexara7777
Copy link
Author

@trey-wallis You're more than welcome, I see, yeah as you mentioned at least the handle should be at the left side instead.

@decaf-dev decaf-dev mentioned this issue May 29, 2023
@decaf-dev
Copy link
Owner

@SaifEl-Deen @MSBack Row drag button is now on the left side in 6.10.0 :)

@Hexara7777
Copy link
Author

@trey-wallis Thank you so much, that was actually fast, much appreciated 🤍

decaf-dev added a commit that referenced this issue Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants