fix code for app_label.

don't use get_app unless actually needed (may code weird cyclic imports in some cases otherwise), and use '%.models' upfront.
jazzband · May 15, 2013 · a683075 · a683075
1 parent ddede10
commit a683075
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/simple_history/models.py b/simple_history/models.py
@@ -44,13 +44,14 @@ def create_history_model(self, model):
         """
         attrs = {'__module__': self.module}
 
-        app_module = models.get_app(model._meta.app_label)
+        app_module = '%s.models' % model._meta.app_label
         if model.__module__ != self.module:
             # registered under different app
             attrs['__module__'] = self.module
-        elif app_module.__name__ != self.module:
+        elif app_module != self.module:
             # has meta options with app_label
-            attrs['__module__'] = app_module.__name__
+            app = models.get_app(model._meta.app_label)
+            attrs['__module__'] = app.__name__ # full dotted name
 
         fields = self.copy_fields(model)
         attrs.update(fields)