Compare history versions #103
Conversation
|
👍 for dropping 1.3 and 1.4 compatibility |
|
I happen to see one of the diffs Groklaw has... I may try to do something like that instead of the word diff that's in this PR currently. I think it'll be a two step diff: Line comparison and words within lines that both changed. |
|
I think side-by-side might be better than inline. |
|
Yeah. One side having the removals, the other the additions. The problem with side-by-side is you need to line up the paragraphs for larger diff's. |
|
@treyhunner, we should probably add Python 3.4 with Django 1.7 to the matrix. Want me to add that here as well? |
|
@macro1 yes please |
|
It's kind of ugly but I think this is much better than nothing. |
|
|
||
|
|
||
| @register.simple_tag | ||
| def diff_table(a, b, line_split="\n"): |
There was a problem hiding this comment.
Should we add unit tests for this?
|
This may be helpful: https://github.com/jeffkaufman/icdiff/blob/master/icdiff I was already looking at |
|
Hi, |
|
I'd love to see someone recreate these changes after #277 is merged. |
|
Closed this with an accepted issue (#396) and will put up an updated PR soon. |
Some initial work on an admin view to compare historical versions. I was having some trouble with compatibility with 1.3 and 1.4 versions of Django admin, so for now I'm ignoring 1.3.
Will resolve #54.