'as_of' for models #106
Merged
'as_of' for models #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| as_of_list = list( | ||
| self.model.history.as_of(self.now - timedelta(days=1))) | ||
| self.assertEqual(as_of_list[0].changed_by, self.obj.changed_by) |
There was a problem hiding this comment.
All of these tests seem to check for only one instance. Should we test that multiple objects can be returned?
|
I made some comments about more test ideas. This looks ready to merge to me. Feel free to merge now or add some more tests and then merge. |
| return history_obj.instance | ||
|
|
||
| def _as_of_set(self, date): | ||
| model = type(self.model().instance) # a bit of a hack to get the model |
There was a problem hiding this comment.
@treyhunner, do you know of a better way of getting at the original model?
macro1
added a commit
that referenced
this pull request
Aug 2, 2014
Extend the 'as_of' method to work as a class method
macro1
added a commit
to macro1/django-simple-history
that referenced
this pull request
Aug 8, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies 'as_of' on the historical manager to return an iterable when no instance is provided.
See discussion in #53