Update models.py

[RossLote]

When using the request middleware, if the user is anonymous an error is raised stating that the 'history_user' attribute must be an instance of User. As this field can be null, get_history_user has been updated to return None if the user is not authenticated. Also made the returning of None explicit.

Fixes #114

[macro1]

Needs a test. Would you mind taking a stab at it?

[RossLote]

@macro1 That's the test committed now. Just waiting for them all to pass. Looking good so far though.

[macro1]

Nice. Unfortunately that test isn't testing for the bug though. If you undo your fix, you will see it still passes. You need to do a 'get' on any page, just to set the request in the local thread variable through the middleware. Make sure you do it inside the context block, so the middleware will have an effect. The other test sets the request in the thread variable as part of logging in.

[RossLote]

@macro1 You mean like that? I've never used django_webtest before.

[macro1]

Before the objects.create, so one line higher.

The idea is the middleware needs to be triggered to make the request available before you do the create, which checks the thread variable for the request, and its user. Right now the request is unset, so it defaults to None and passes every time without making the is_authenticated check.

[RossLote]

Oh yeah, silly me. I was too busy trying to find a page that I could do a get request on I over looked the order.