Indicate non-coverage areas #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we should mark these as uncovered. If you run the tests with |
macro1
force-pushed
the
true-coverage
branch
from
fbf52cc
to
7f7da9e
Compare
|
Changes made. I think it's more straight-forward to worry about one version at a time, but I can see the merits in this as well. |
|
Looks good to me 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I marked the lines we don't plan on hitting in the primary test run (Django 1.7 on Python 3.4) with the 'no cover' coverage pragma and marked the reason for the compatability: The version of Django if that was the reason, or a short description if it was something else.
I also removed the compatibility we had for Django versions older than 1.4 that did not have the timezone util module.