Add Django 1.8 support #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh. I just realized what could be causing the error. The model doesn't exist still the tests are started, so it wasn't part of the test db setup. I'm not sure why I can't reproduce it locally, but that makes sense I think. |
This was referenced Apr 4, 2015
|
Awesome, thanks Micah! |
|
This bring 1.8 comparability to master, there will be a release soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been a couple pull requests, so I decided to make a pull request of what I have so far. As noted in #156 the internal API for related fields has changed and the
relandrelatedfield attributes have merged.Initially I looked at maintaining what we currently have with CustomForeignKey, but I don't think it would be wise to continue supporting it in the future if there is any chance of removing it. The code bellow appears to work for 1.8, I haven't worked through making it backward compatible.
@rodxavier or @RossLote: If this helps you sort out one of your branches, please update or reopen your PR so we can add support once we find a fix.
Closes #157
Resolves #156