Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTTPS #12

Open
JamesDAdams opened this issue Oct 13, 2020 · 8 comments · May be fixed by #24
Open

Add HTTPS #12

JamesDAdams opened this issue Oct 13, 2020 · 8 comments · May be fixed by #24

Comments

@JamesDAdams
Copy link

Hi,

I added the https but there is no parameter to activate it for this container...

Mu docker container:

docker run -d --name quakejs
-e SERVER=quakejs.domainename.com
-e HTTP_PORT=80
-p 10113:80
-p 27960:27960
-l traefik.enable="true"
-l traefik.http.routers.quakejs.rule="Host(quakejs.domainename.com)"
-l traefik.http.routers.quakejs.entrypoints="websecure"
-l traefik.http.services.quakejs.loadbalancer.server.port=80
treyyoder/quakejs:latest

Sans titre

( i replace my domaine per domainename ^^)
@purvaldur
Copy link

Bump - I encountered this issue as well. No idea how to workaround

@morganzero
Copy link

BUMP!

@samkasman
Copy link

Also trying to figure out how to get it to work via Traefik/HTTPS, no luck

@treyyoder
Copy link
Owner

Have you tried a reverse proxy? Like nginx?

@morganzero
Copy link

Have you tried a reverse proxy? Like nginx?

I've tried Traefik Reverse Proxy

@stp14
Copy link

stp14 commented May 17, 2023

Bumping this! I also have tried with nginx and have the same issue. I went into the code (ioquake3.js and ioq3ded.js) and changed http to https where it sets the url variable - lines 15227 and 15277 in ioquake3.js, and lines 9532 and 9404 in ioq3ded.js

Doing that gave me the following error related to ioq3ded.js under the ----- FS_Startup ----- header:
TypeError [ERR_INVALID_PROTOCOL]: Protocol "https:" not supported. Expected "http:"

On the nginx side, I've tried adding proxy_set_header X-Forwarded-Proto https as well as a sub_filter to try to force https with no luck.

@stp14 stp14 mentioned this issue May 17, 2023
Open
@realies realies linked a pull request Dec 24, 2023 that will close this issue
Open
@realies
Copy link

realies commented Dec 24, 2023

@stp14, please try the changes in #24. This should allow for an easy reverse proxy setup.

@madsboddum
Copy link

Encountered this yesterday as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

upgrade, add dynamic protocol and hostname support realies/quakejs-docker
8 participants
@treyyoder @madsboddum @realies @purvaldur @samkasman @JamesDAdams @morganzero @stp14