Skip to content
This repository has been archived by the owner on Nov 23, 2023. It is now read-only.

SignMessage updates #941

Closed
andrewkozlik opened this issue Nov 15, 2021 · 0 comments · Fixed by #942
Closed

SignMessage updates #941

andrewkozlik opened this issue Nov 15, 2021 · 0 comments · Fixed by #942

Comments

@andrewkozlik
Copy link
Contributor

There are several changes in the handling of SignMessage in Trezor firmware, which may require updates in trezor-connect.

The PR trezor/trezor-firmware#1903 implemented these changes in the SignMessage protobuf flow:

  • A new screen was added showing the address being used for signing in SignMessage and EthereumSignMessage on T1 and TT.
  • A new bool parameter was added to SignMessage in T1 and TT called no_script_type, which is false by default and when set to true SignMessage does not include script type information in the recovery byte of the signature, same as in Bitcoin Core. Needed for AOPP AOPP support trezor-suite#4512.
  • Pagination in SignMessage was implemented on T1 to be able to display long messages.
  • In T1 some ButtonRequests in SignMessage have been changed from ProtectCall to Other to unify behavior with TT. (TT currently always uses Other.)

The Taproot PRs trezor/trezor-firmware#1891 and trezor/trezor-firmware#1917 introduce one change to the SignMessage flow:

  • If the requested path doesn't match the script type, then a warning dialog in SignMessage will be shown before displaying the address. This is the same behavior as in GetAddress.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant