Skip to content
This repository has been archived by the owner on May 28, 2019. It is now read-only.

Remove Stellar(Get)PublicKey #325

Closed
tsusanka opened this issue Aug 20, 2018 · 5 comments
Closed

Remove Stellar(Get)PublicKey #325

tsusanka opened this issue Aug 20, 2018 · 5 comments

Comments

@tsusanka
Copy link
Contributor

Remove StellarGetPublicKey and StellarPublicKey messages? The sign/verify functions were removed so I'm not sure we want to keep this

@tsusanka
Copy link
Contributor Author

@zulucrypto is that okay for you? The pubkey is not used anywhere now, so I think it's better when we remove it. In case the sign/verify functions return, we'll restore this as well

@zulucrypto
Copy link
Contributor

I was planning on using this method when I implemented support for the account viewer so I think it's still necessary.

Usually people only have one Stellar address that they use multiple times, so this method is important to allow people to get their public address that they can share with others.

@tsusanka
Copy link
Contributor Author

tsusanka commented Aug 21, 2018

I'm confused. Isn't that what's GetAddress for? Which we plan to keep

@zulucrypto
Copy link
Contributor

Oops, my mistake, I forgot they were separate! Yes, getPublicKey can be removed.

@tsusanka
Copy link
Contributor Author

Removed in 4305c1d

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants