Sending to Taproot addresses #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prusnak
requested changes
Oct 15, 2021
prusnak
approved these changes
Oct 16, 2021
matejcik
approved these changes
Oct 18, 2021
enable for Bitcoin Testnet and Bitcoin Regtest
because they encode segwit program > 0 and these should no longer be encoded with Bech32 but rather with Bech32m
because they encode segwit program > 0 and these should no longer be encoded with Bech32 but rather with Bech32m
andrewkozlik
force-pushed
the
andrewkozlik/taproot-send
branch
from
d958bf9
to
76b5fd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements two basic features for Taproot in T1 and TT:
GetPublicKeyand descriptors for Taproot.For this PR I mainly picked the commits from the
taprootbranch that have no remaining TODOs and finished what needed to be done for sending BTC to Taproot addresses. This means that a lot of the code has already been reviewed, so I ask that the reviewers mainly go over my two commits and do a final lookover.It would be good to get this merged into the
masterbranch before the freeze on 22nd of October, so that it can go into the November release. Taproot activation is expected in mid November. This is as much as we can do without secp256k1_zpk #1678, which will probably take a while longer. So it seems unrealistic that we will be able to squeeze in anything else into the November release.