fix(python): use unified descriptor format <a;b> #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prusnak
force-pushed
the
unified-descriptors
branch
2 times, most recently
from
2755f4a
to
21521d4
Compare
|
please add changelog entry. in |
prusnak
force-pushed
the
unified-descriptors
branch
from
21521d4
to
5dc60b3
Compare
Added in 5dc60b3 |
matejcik
approved these changes
Nov 4, 2021
python/src/trezorlib/cli/btc.py
Outdated
| ds = _get_descriptor(client, coin, account, script_type, show_display) | ||
| for d in ds: | ||
| click.echo(d) | ||
| d = _get_descriptor(client, coin, account, script_type, show_display) |
There was a problem hiding this comment.
fwiw you can just return _get_descriptor(...) instead of echoing it
|
you need to re-run UI tests because the testcase identifiers have changed. |
|
Review addressed in a86eb3a |
|
👍 please squash the fixup and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use unified descriptor format introduced in bitcoin/bitcoin#22838