Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cardano support with Shamir #272

Closed
ZdenekSL opened this issue Jun 27, 2019 · 3 comments · Fixed by #359
Closed

Cardano support with Shamir #272

ZdenekSL opened this issue Jun 27, 2019 · 3 comments · Fixed by #359
Assignees
Labels
bug Something isn't working as expected
Projects
Milestone

Comments

@ZdenekSL
Copy link
Contributor

ZdenekSL commented Jun 27, 2019

Child of #269
Fix Cardano support with Shamir seed.

@ZdenekSL ZdenekSL added bug Something isn't working as expected S3 Major labels Jun 27, 2019
@ZdenekSL ZdenekSL added this to the 2019-08 milestone Jun 27, 2019
@tsusanka tsusanka self-assigned this Jul 1, 2019
@tsusanka
Copy link
Contributor

tsusanka commented Jul 2, 2019

@refi93 we are introducing a new form of recovery system, called Shamir backup, defined in SLIP-0039 (a somewhat replacement for BIP-39). I'm trying to figure out how to support Cardano on top of this, in particular here.

You are calling bip32.from_mnemonic_cardano, which converts the BIP-39 mnemonic to entropy and then calls hdnode_from_seed_cardano. I'm a bit confused why not call bip39.mnemonic_to_seed() before and insert the seed into hdnode_from_seed_cardano. Is there any difference? Or do we need to call
mnemonic_to_entropy, which is needed for Cardano?

I know it's quite some time ago already, so let me know if you don't know. Thanks!

@andrewkozlik
Copy link
Contributor

I created SLIP-0023 to solve this issue, see https://github.com/satoshilabs/slips/blob/andrewkozlik/slip-0023/slip-0023.md. In https://forum.cardano.org/t/cardano-with-slip-0039/25443 I asked people to make comments on the new specification in the pull request satoshilabs/slips#712.

I opened a pull request #359, but it needs careful testing.

@andrewkozlik
Copy link
Contributor

I tested #359 on the device to make sure that it gives the same addresses as the SLIP-0023 test vectors. So it should be fine, but testers should also try some Cardano transactions on a Trezor using SLIP-0039 to ensure that everything is in order.

Shamir automation moved this from To do to Done Jul 26, 2019
@andrewkozlik andrewkozlik added W20 and removed W5 labels Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected
Projects
No open projects
Shamir
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants