Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Implement full WebAuthn/FIDO2 #39

Closed
prusnak opened this issue Apr 16, 2019 · 8 comments
Closed

[Epic] Implement full WebAuthn/FIDO2 #39

prusnak opened this issue Apr 16, 2019 · 8 comments
Assignees
Labels
core Trezor Core firmware. Runs on Trezor Model T and T2B1. epic Issue that aggregates a larger area of tasks.
Projects
Milestone

Comments

@prusnak
Copy link
Member

prusnak commented Apr 16, 2019

Currently, we do U2F, but let's expand the functionality to full WebAuthn (aka FIDO2) support.

Subtasks:
#245 Add support for FIDO2 resident credentials
#206 Implement FIDO2 credential selection
#205 Redesign FIDO2 credential ID format
#31 Modify U2F/webauthn app to use Keychain

@prusnak prusnak changed the title Implement full WebAuthn Implement full WebAuthn/FIDO2 Apr 16, 2019
@prusnak prusnak added core Trezor Core firmware. Runs on Trezor Model T and T2B1. feature labels Apr 16, 2019
@prusnak prusnak added this to the backlog milestone Apr 16, 2019
@prusnak prusnak added T1B1 legacy Trezor One core Trezor Core firmware. Runs on Trezor Model T and T2B1. and removed core Trezor Core firmware. Runs on Trezor Model T and T2B1. labels Apr 16, 2019
@prusnak prusnak modified the milestones: backlog, 2019-07 May 23, 2019
@prusnak
Copy link
Member Author

prusnak commented May 23, 2019

Mainly we are interested in parsing Application+User data from the protocol and showing that on the display.

@andrewkozlik
Copy link
Contributor

Pull request: #204

Regression testing: Focus on U2F and Cardano. Ensure that logging in with a U2F credential that was created prior to firmware upgrade works correctly.

@ZdenekSL ZdenekSL modified the milestones: 2019-07 , 2019-08 Jun 26, 2019
@andrewkozlik
Copy link
Contributor

andrewkozlik commented Jul 9, 2019

Subtasks:
#245 Add support for FIDO2 resident credentials
#206 Implement FIDO2 credential selection
#205 Redesign FIDO2 credential ID format
#31 Modify U2F/webauthn app to use Keychain

@ZdenekSL ZdenekSL added this to To do in FIDO2 via automation Jul 10, 2019
@prusnak prusnak added the epic Issue that aggregates a larger area of tasks. label Jul 10, 2019
@ZdenekSL ZdenekSL modified the milestones: 2019-08, 2019-09 Aug 1, 2019
@ZdenekSL ZdenekSL changed the title Implement full WebAuthn/FIDO2 [Epic] Implement full WebAuthn/FIDO2 Aug 10, 2019
@andrewkozlik
Copy link
Contributor

The FIDO2 implementation for Trezor T is currently undergoing review #394. If all goes well, we can release this in September. There are several options for the release:

  1. Release FIDO2 in stable firmware for all users.
  2. Release FIDO2 for beta testing in stable firmware. The feature would need to be activated via trezorctl.
  3. Release FIDO2 for beta testing in separate firmware.

I would prefer option 3 as it is the safest and cleanest solution. The full release of FIDO2 can happen in October. From the marketing perspective there is no rush, because in September the focus will be on Shamir Backup. I expect @prusnak to make the final decision on this and @ZdenekSL to communicate the decision with marketing.

@prusnak prusnak removed the T1B1 legacy Trezor One label Aug 19, 2019
@prusnak prusnak modified the milestones: 2019-09, 2019-10 Aug 20, 2019
@prusnak prusnak moved this from To do to In progress in FIDO2 Sep 13, 2019
@tsusanka
Copy link
Contributor

The only thing missing is #245, which is tracked in its own issue. Closing.

FIDO2 automation moved this from In progress to Done Sep 18, 2019
@Quiark
Copy link

Quiark commented Dec 7, 2019

Is there any plan to implement FIDO2 for Trezor One?

On the shop page it's marked as supported ...

image

@prusnak
Copy link
Member Author

prusnak commented Dec 7, 2019

@Quiark That's a bug on our website which will be fixed soon. Currrently, we don't plan to support FIDO2 on Trezor One.

@1000i100
Copy link

What a shame !
Is there lot's of work to do it, or is it marketing choice ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Trezor Core firmware. Runs on Trezor Model T and T2B1. epic Issue that aggregates a larger area of tasks.
Projects
No open projects
FIDO2
  
Done
Development

No branches or pull requests

6 participants