decred: Add input_derive_script. #2703
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeGruffins
force-pushed
the
fixdecredinputcheck
branch
from
cbd740f
to
53801fd
Compare
Decred shares code with bitcoin and a recent change broke signing stake based inputs. Add decred specific script construction and fix tests.
JoeGruffins
force-pushed
the
fixdecredinputcheck
branch
from
53801fd
to
2b47bd6
Compare
|
@matejcik Hey buddy. Any chance you could have a look at this. Almost a year old. Thanks. |
|
IIUC, this change is needed to stake Decred coins. This is the remaining blocker for me and other Decred holders. We could finally use our Model T’s for Decred, after all these years. |
|
@matejcik please merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced by c9e6ca3
This is partly my fault as the test input was flawed and did not have the proper script opcode prefix.
Feel free to take these changes and adjust as you like. I do not need credit. Just hope to get the bug fixed asap.