Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

step_is_waveform is not general, only corresponds to maccor #204

Open
ardunn opened this issue Mar 25, 2021 · 0 comments
Open

step_is_waveform is not general, only corresponds to maccor #204

ardunn opened this issue Mar 25, 2021 · 0 comments
Labels
bug Something isn't working structuring

Comments

@ardunn
Copy link
Collaborator

ardunn commented Mar 25, 2021

step_is_waveform only works with maccor files.

it can be implemented on a datapath-by-datapath basis so that everything specific to Maccor waveform goes in MaccorDatapath, everything specific to Arbin waveform goes in ArbinDatapath, etc. Like a method step_is_waveform.

The default in BEEPDatapath ABC can be evaluating to false, with a log printed that says waveform is not implemented for this specific cycler.

Right now waveform steps will evaluate to false even if there is waveform (e.g., arbin waveform) and there is no logging or indication the step actually is waveform, it just returns false.

@ardunn ardunn added bug Something isn't working structuring labels Mar 25, 2021
@ardunn ardunn mentioned this issue Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working structuring
Projects
None yet
Development

No branches or pull requests

1 participant