Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RealtimeMeshAlgo::GenerateTangents type mismatch fixes #269

Closed
k0kz opened this issue Jan 16, 2024 · 1 comment
Closed

RealtimeMeshAlgo::GenerateTangents type mismatch fixes #269

k0kz opened this issue Jan 16, 2024 · 1 comment

Comments

@k0kz
Copy link
Contributor

k0kz commented Jan 16, 2024

C4018 (type mismatch) fixes

Line 375

for (int32 TriIdx = 0; TriIdx < NumTris; TriIdx++)

Changed to:

for (uint32 TriIdx = 0; TriIdx < NumTris; TriIdx++)

Lines 483 and 508

for (int VertxIdx = 0; VertxIdx < NumVertices; VertxIdx++)

Changed to:

for (uint32 VertxIdx = 0; VertxIdx < NumVertices; VertxIdx++)

2672 (no matching overload) fixes

Line 383 (when Triangles TArray uses int32 instead of uint 32)

uint32 VertIndex = FMath::Min(Triangles[(TriIdx * 3) + CornerIdx], NumVertices - 1);

Changed to:

uint32 VertIndex = FMath::Min(uint32(Triangles[(TriIdx * 3) + CornerIdx]), NumVertices - 1);
@Koderz
Copy link
Member

Koderz commented Mar 2, 2024

Hey @k0kz

This should be fixed with your PR in master!

Thanks,
-Chris

@Koderz Koderz closed this as completed Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants