Add http_timeout configuration setting to configure timeout when gett… #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Can you add a note to the readme about this new config value? |
Kircheneer
force-pushed
the
lk-http-timeout
branch
from
7b2fd5d
to
2099a97
Compare
…ing document via HTTP.
Kircheneer
force-pushed
the
lk-http-timeout
branch
from
2099a97
to
8386801
Compare
|
Codecov Report
@@ Coverage Diff @@
## main #718 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 49 49
Lines 1970 1971 +1
=========================================
+ Hits 1970 1971 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ing document via HTTP.
I was trying to generate a client for Nautobot but this failed due to a timeout. I have added a corresponding setting to alleviate this. The default 5s timeout for
httpx.getwas not enough to allow the endpoint to return in time.