Fixed special agent Netapp command line creation. #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LarsMichelsen
pushed a commit
that referenced
this pull request
Apr 27, 2021
This werk fixes a bug in the NetApp special agent which caused the agent to crash with <tt>agent_netapp: error: unrecognized arguments: ...</tt>. Closes #366. Change-Id: Ic831a8e906f2c02b9afdde902edb7c2d3636a5a0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original created command line for Netapp special agent
/omd/sites/cmk/share/check_mk/agents/special/agent_netapp '-u' 'user' '-s' 'password' '--nocounters volumes' '127.0.0.1'
usage: agent_netapp [-h] [-u USER] [-s SECRET] [--vcrtrace TRACEFILE] [-t TIMEOUT] [--nocounters {volumes}] [--xml] [--debug] [--legacy] host_address
agent_netapp: error: unrecognized arguments: 127.0.0.1
Bugfixed
/omd/sites/cmk/share/check_mk/agents/special/agent_netapp '-u' 'user' '-s' 'password' '--nocounters' 'volumes' '127.0.0.1'
<<<netapp_api_connection>>>
.......
Thank you for your interest in contributing to Checkmk! Unfortunately, due to our current work load,
we can at the moment only consider pure bugfixes, as stated in our
Readme. Thus, any new pull request which
is not a pure bugfix will be closed. Instead of creating a PR, please consider sharing new check
plugins, agent plugins, special agents or notification plugins via the
Checkmk Exchange.