BUG: Meinberg fan state shows wrong state

[Yogibaer75]

In the check the state was switched between on and off.
Correct values from here

mbgLtNgSysFanStatus | 1.3.6.1.4.1.5597.30.0.5.1.2.1.2
Status of fan
Status: current
OBJECT-TYPE  | INTEGER | notAvailable(0), off(1), on(2)

This bug affects all versions 1.6/2.0/2.1 and so on :)

Thank you for your interest in contributing to Checkmk!
Unfortunately, due to our current work load, we only consider pure bug fixes as stated in our Readme.
This means any new pull request that is not a pure bug fix will be closed.
Instead of creating a PR, please consider sharing new check plugins, agent plugins, special agents or notification plugins via the Checkmk Exchange.

General information

Please give a brief summary of the affected device, software or appliance.
Keep in mind that we are experts in monitoring, but we cannot be experts on all supported devices.
A little context will help us assess your proposed change.

Bug reports

Please include:

• Your operating system name and version
• Any details about your local setup that might be helpful in troubleshooting
• Detailed steps to reproduce the bug
• An agent output or SNMP walk
• The ID of a submitted crash report for reference (if applicable)

Proposed changes

Sometimes it is hard for us to assess the quality of a fix.
While it may work for you, it is our job to ensure that it works for everybody.
These are some ways to help us:

• What is the expected behavior?
• What is the observed behavior?
• If it's not obvious from the above: In what way does your patch change the current behavior?
• Consider writing a unit test that would have failed without your fix.
• Is this a new problem? What made you submit this PR (new firmware, new device, changed device behavior)?
  mbgLtNgSysFanStatus 1.3.6.1.4.1.5597.30.0.5.1.2.1.2
  Status of fan
  Status: current Access: read-only
  OBJECT-TYPE
  INTEGER notAvailable(0), off(1), on(2)

[kain88-de]

Since there is no link can you tell me the source of the correct values if possible? I'll merge this shortly

[Yogibaer75]

The Link is directly on the value "mbgLtNgSysFanStatus" or here in clear text
https://www.circitor.fr/Mibs/Html/M/MBG-SNMP-LTNG-MIB.php#mbgLtNgSysFanStatus

[kain88-de]

I backported the fix to 2.1 and 2.0.

1.6 is in passive maintenance now, and I would really prefer if people upgrade from 1.6 to something newer.

https://docs.checkmk.com/latest/en/cmk_versions.html#support_periods