Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex does not catch every PoC occurrence #4

Closed
dhondta opened this issue Feb 11, 2022 · 1 comment
Closed

Regex does not catch every PoC occurrence #4

dhondta opened this issue Feb 11, 2022 · 1 comment

Comments

@dhondta
Copy link
Contributor

dhondta commented Feb 11, 2022

Consider adapting your regex to something case-insensitive like the following :

(?i)[^a-z0-9]+(poc|proof of concept|proof-of-concept)[^a-z0-9]+

I've already seen some examples of PoC's not caught for CVE's that are well in your repo, therefore resulting in "No GitHub POC found".

@dhondta dhondta mentioned this issue Feb 11, 2022
@mhmdiaa
Copy link
Contributor

mhmdiaa commented Feb 11, 2022

Hey @dhondta, I've just merged #5. The updated regex is now part of the workflow! We've also made some adjustments to the search client so you should see improved results in the next patch.

Thanks a lot for your contribution!

@mhmdiaa mhmdiaa closed this as completed Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants