Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic version numbers #27

Open
bovine3dom opened this issue Feb 6, 2021 · 3 comments
Open

Automatic version numbers #27

bovine3dom opened this issue Feb 6, 2021 · 3 comments

Comments

@bovine3dom
Copy link
Member

https://github.com/achesak/nim-gitapi/blob/master/gitapi.nim

I reckon version = last git tag + (if tag isn't at head: short commit hash)

Probably needs to go in the nimble build script.

At the moment it's easy for the version number and the tag to diverge, and for PRs to fight over version numbers.

@bovine3dom
Copy link
Member Author

Hmm, semver-compare as used in nativegate treats version numbers with extra alphanumeric bits as smaller than ones without:

> cmp("0.1.1d", "0.1.1")
-1

So we'll probably need to increment the last digit of the git tag.

@Rummskartoffel
Copy link
Contributor

Considering semver-compare is only 13 lines of code, it shouldn't be too hard to roll our own that does what we want.

@bovine3dom
Copy link
Member Author

I was thinking of the backwards compatibility.

I suppose it doesn't matter if we're adding new things to Tridactyl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants