Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the i18n api for CSS #1837

Closed
glacambre opened this issue Sep 9, 2019 · 3 comments · Fixed by #3462
Closed

Use the i18n api for CSS #1837

glacambre opened this issue Sep 9, 2019 · 3 comments · Fixed by #3462

Comments

@glacambre
Copy link
Member

There are a few places in Tridactyl's CSS files where I used base64 icons because I couldn't find a way to load images from the extension's storage. I think these base64 icons can be replaced with urls to Tridactyl's resources if said URLs use the i18n API in order to specify absolute paths containing Tridactyl's UUID.

@rektrex
Copy link
Contributor

rektrex commented Sep 12, 2019

I would like to take on this one. Where should the images directory be stored - root of the project or src/static?

@glacambre
Copy link
Member Author

I think they should go in static. Thanks for doing this :)

@rektrex
Copy link
Contributor

rektrex commented Sep 12, 2019

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants