Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore comments starting with # from rc file #3100

Closed
bew opened this issue Dec 13, 2020 · 0 comments
Closed

Ignore comments starting with # from rc file #3100

bew opened this issue Dec 13, 2020 · 0 comments

Comments

@bew
Copy link
Contributor

bew commented Dec 13, 2020

Tridactyl version: 1.20.3
Firefox version: Mozilla Firefox 83.0
Operating system: linux

Currently rc file loading only ignore empty lines and lines starting with vim'like comments ", however # seems to work as well as a comment in rcfile.

Since each excmd is executed with a delay (to workaround #1409 for now), each of the # comments I use adds loading time for nothing.

Src to change:

return excmds.filter(x => /\S/.test(x) && !x.trim().startsWith('"'))

@bew bew changed the title Ignore comments stating with # from rc file Ignore comments starting with # from rc file Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant