Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cached version of page has wrong language context #106

Closed
schliflo opened this issue Feb 3, 2021 · 2 comments
Closed

Cached version of page has wrong language context #106

schliflo opened this issue Feb 3, 2021 · 2 comments
Assignees
Labels
bug Something isn't working fixed Issue has already been fixed

Comments

@schliflo
Copy link
Contributor

schliflo commented Feb 3, 2021

Following up on https://discord.com/channels/501836936584101899/506916956637495306/806574179578544148

Steps to reproduce:

  • create a fresh grav project composer create-project getgrav/grav
  • change to flex pages by adding type: flex to the pages settings in the system.yaml
  • add a new file pages/01.home/default.de.md and add some content
  • add the following language settings to system.yaml
    default_locale: de
    languages:
      supported:
         - en
         - de
      default_lang: en
      content_fallback:
        de:
          - en
  • load the de homepage by adding /de/
  • everything looks fine on the first hit (page shows content of pages/01.home/default.de.md)
  • reload page
  • page shows content of en version (pages/01.home/default.md) despite of being in de context

I think this might be an issue with the caching or with flex itself - either way, this was working in previous versions (certainly before the 1.7 stable release). If you need info on the exact version where this was working I can dig a bit in our codebase to get it.
Please let me know if I can help any further or you need more information.
And thank you guys for taking care, this is really appreciated!

@rhukster rhukster added the bug Something isn't working label Feb 3, 2021
@mahagr
Copy link
Contributor

mahagr commented Feb 5, 2021

Bug confirmed.

@mahagr
Copy link
Contributor

mahagr commented Feb 5, 2021

Fixed in Grav: getgrav/grav@830fa40

@mahagr mahagr added the fixed Issue has already been fixed label Feb 5, 2021
@mahagr mahagr closed this as completed Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed Issue has already been fixed
Projects
None yet
Development

No branches or pull requests

3 participants