Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove admin plugin as dependency #130

Closed
bitstarr opened this issue Jun 9, 2021 · 2 comments
Closed

Remove admin plugin as dependency #130

bitstarr opened this issue Jun 9, 2021 · 2 comments
Assignees
Labels
fixed Issue has already been fixed

Comments

@bitstarr
Copy link
Contributor

bitstarr commented Jun 9, 2021

I want to be able to run a grav website on production server without the admin interface (for security e.g.).
When I run:

./bin/gpm selfupgrade
./bin/gpm update

or

./bin/grav install

it will force the installation of the admin plugin.

Please remove this dependency, as flex-objects is capable to work without it.

@w00fz w00fz self-assigned this Jun 9, 2021
@w00fz w00fz closed this as completed in 7bfde54 Jun 9, 2021
@w00fz
Copy link
Member

w00fz commented Jun 9, 2021

You are right this is not a dependency, what we need is for a way for resources to be able to specify satisfactory version requirements of other resources, without necessary turning them into their own dependencies.

In this case Flex Objects was trying to ensure that if you had Admin installed, it was running at least version X, unfortunately this in turn made Admin a dependency of Flex Objects.

@bitstarr
Copy link
Contributor Author

bitstarr commented Jun 9, 2021

I think there should still be a way to note the minimum version of the admin plugin. This seems to be critical. But maybe there should be a check for this in the code of flex objects. Something that displays a message in the admin like 'This version of admin is not compatible with the current version of flex objects. Please update'

@mahagr mahagr added the fixed Issue has already been fixed label Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Issue has already been fixed
Projects
None yet
Development

No branches or pull requests

3 participants