Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GuzzleHttp version conflicting with other plugins for lack of centralized libraries #41

Open
drzraf opened this issue Nov 11, 2021 · 1 comment

Comments

@drzraf
Copy link
Contributor

drzraf commented Nov 11, 2021

I would like to bring your attention on stephan-strate/grav-plugin-logger-channels#4

  • grav-plugin-login-oauth2 : guzzlehttp/guzzle : 6.5.4, GuzzleHttp::choose_handler()
  • grav-plugin-logger-channels : guzzlehttp/guzzle : 7.2.0, GuzzleHttp\Utils::chooseHandler()

Both do return require __DIR__ . '/vendor/autoload.php'; (and corresponding spl_autoload_register with different entries for GuzzleHttp) in a first-win fashion which make both plugins de facto incompatibles.

I'm pretty sure it's not the first time such an issue arise since it's deemed to happen if each plugin manages its own set of dependencies (which are likely redundant across a Grav installation).

@mahagr
Copy link
Contributor

mahagr commented Nov 11, 2021

Yes, this is the downside of plugins using vendor libraries. Sometimes they even conflict with Grav itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants