Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShyLu broken cmake config #7338

Closed
VictorEijkhout opened this issue May 9, 2020 · 14 comments
Closed

ShyLu broken cmake config #7338

VictorEijkhout opened this issue May 9, 2020 · 14 comments
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. PA: Framework Issues that fall under the Trilinos Framework Product Area type: bug The primary issue is a bug in Trilinos code or tests

Comments

@VictorEijkhout
Copy link

My attempt to install dealii floundered on the fact that you guys leave behind broken Cmake configuration files. No worry: I'm running a sed script after the trilinos install to fix the files you generate.

But in case you feel ike fixing the problem, here's documentation for this particular case:

%%%%%%%%%%%%%%%%%%%%%
The actual error message (and why configure fails) is here:

12442 -- Include /admin/build/admin/rpms/frontera/BUILD/dealii-9.1.1/cmake/configure/configure_2_trilinos.cmake
12443 CMake Error at /home1/apps/intel19/impi19_0/trilinos/12.18.1/lib/cmake/ShyLU/ShyLUConfig.cmake:156 (INCLUDE):
12444 INCLUDE could not find load file:
12445
12446 /home1/apps/intel19/impi19_0/trilinos/12.18.1/lib/cmake/ShyLU/../ShyLU_Node/ShyLU_NodeConfig.cmake
12447 Call Stack (most recent call first):
12448 /home1/apps/intel19/impi19_0/trilinos/12.18.1/lib/cmake/Trilinos/TrilinosConfig.cmake:130 (INCLUDE)
12449 cmake/macros/macro_find_package.cmake:27 (_FIND_PACKAGE)
12450 cmake/modules/FindTRILINOS.cmake:38 (FIND_PACKAGE)
12451 cmake/macros/macro_find_package.cmake:27 (_FIND_PACKAGE)
12452 cmake/configure/configure_2_trilinos.cmake:22 (FIND_PACKAGE)
12453 /tmp/dealii-build/CMakeFiles/CMakeTmp/evaluate_expression.tmp:1 (FEATURE_TRILINOS_FIND_EXTERNAL)
12454 cmake/macros/macro_evaluate_expression.cmake:30 (INCLUDE)
12455 cmake/macros/macro_configure_feature.cmake:237 (EVALUATE_EXPRESSION)
12456 cmake/configure/configure_2_trilinos.cmake:303 (CONFIGURE_FEATURE)
12457 cmake/macros/macro_verbose_include.cmake:19 (INCLUDE)
12458 CMakeLists.txt:124 (VERBOSE_INCLUDE)

This implies that the CMake configuration that gets installed by
Trilinos is broken.

The file

/home1/apps/intel19/impi19_0/trilinos/12.18.1/lib/cmake/ShyLU/ShyLUConfig.cmake

contains an include on line 156

INCLUDE("${CMAKE_CURRENT_LIST_DIR}/../ShyLU_Node/ShyLU_NodeConfig.cmake")

pointing to a nonexistant file

/home1/apps/intel19/impi19_0/trilinos/12.18.1/lib/cmake/ShyLU/../ShyLU_Node/ShyLU_NodeConfig.cmake
%%%%%%%%%%%%%%%%%%%%%%%

@VictorEijkhout VictorEijkhout added the type: bug The primary issue is a bug in Trilinos code or tests label May 9, 2020
@srajama1
Copy link
Contributor

@jwillenbring Do you know a reason why ShyLConfig.cmake is present and ShyLU_NodeConfig.cmake won't be there ?

@VictorEijkhout Can you give me your configure script ?

@VictorEijkhout
Copy link
Author

VictorEijkhout commented May 10, 2020 via email

@srajama1
Copy link
Contributor

@VictorEijkhout : The configure is not doing anything non-stanadard, let me see if @jwillenbring has any suggestions from the @trilinos/framework side.

@jwillenbring
Copy link
Member

This could be related to how ShyLU is set up in terms of an unusual sub-package structure.
@bartlettroscoe or @prwolfe do you have any thoughts on this?

@bartlettroscoe
Copy link
Member

This could be related to how ShyLU is set up in terms of an unusual sub-package structure.

@jwillenbring, not sure. It is possible this is related to the fact that the current ShyLU package is a pseduo package that has not native libraries or tests. (This may be a hole in the current TriBITS testing.)

In the short term, try just directly including the standard TriBITS packages ShyLU_NodeConfig.cmake and ShyLU_DDConfing.cmake in the sort term.

In the medium and long terms, all of this <Package>Config.cmake code is going to get some serious attention as part of the work outlined in TriBITSPub/TriBITS#63 and TriBITSPub/TriBITS#299.

@prwolfe
Copy link
Contributor

prwolfe commented May 12, 2020

I did a naive test

  • built ShyLU with gcc 8.3.0
  • installed locally
  • created a CMakeLists.txt file with nothing but find_package(Trilinos)

This worked even if I asked for ShyLU as a component. Short of a more significant test I am stumped as to what issue @VictorEijkhout is seeing.

@VictorEijkhout
Copy link
Author

VictorEijkhout commented May 12, 2020 via email

@srajama1
Copy link
Contributor

@jwillenbring : @VictorEijkhout has a good point in terms of testing (though I don't know what special thing Deal.ii is doing here). Can you add it to the leaders meeting agenda ?

@VictorEijkhout
Copy link
Author

VictorEijkhout commented May 12, 2020 via email

@srajama1
Copy link
Contributor

@VictorEijkhout Yes, that would be useful.

@VictorEijkhout
Copy link
Author

VictorEijkhout commented May 12, 2020 via email

@srajama1
Copy link
Contributor

srajama1 commented Jun 3, 2020

@trilinos/framework : Can we add integration tests with deal.ii ?

@srajama1 srajama1 added the PA: Framework Issues that fall under the Trilinos Framework Product Area label Jun 3, 2020
@github-actions
Copy link

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

@github-actions github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Dec 26, 2021
@github-actions
Copy link

This issue was closed due to inactivity for 395 days.

@github-actions github-actions bot added the CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. label Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. PA: Framework Issues that fall under the Trilinos Framework Product Area type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Development

No branches or pull requests

5 participants