a few issues from static code analyzer PVS

[davydden]

/home/davydden/spack/opt/spack/linux-ubuntu16-x86_64/gcc-5.4.0/trilinos-12.8.1-fwmxwfpiqrrolya5mboyv6jvbz6imq4s/include/Epetra_FECrsGraph.h	65	warn	V690 The '=' operator is declared as private in the 'Epetra_FECrsGraph' class, but the default copy constructor will still be generated by compiler. It is dangerous to use such a class.
/home/davydden/spack/opt/spack/linux-ubuntu16-x86_64/gcc-5.4.0/trilinos-12.8.1-fwmxwfpiqrrolya5mboyv6jvbz6imq4s/include/AztecOO.h	84	warn	V690 The 'AztecOO' class implements a copy constructor, but lacks the '=' operator. It is dangerous to use such a class.
/home/davydden/spack/opt/spack/linux-ubuntu16-x86_64/gcc-5.4.0/trilinos-12.8.1-fwmxwfpiqrrolya5mboyv6jvbz6imq4s/include/Teuchos_CompObject.hpp	65	warn	V690 The 'CompObject' class implements a copy constructor, but lacks the '=' operator. It is dangerous to use such a class.
/home/davydden/spack/opt/spack/linux-ubuntu16-x86_64/gcc-5.4.0/trilinos-12.8.1-fwmxwfpiqrrolya5mboyv6jvbz6imq4s/include/Teuchos_SerialDenseMatrix.hpp	464	warn	V560 A part of conditional expression is always false: ScalarTraits < ScalarType >::isComplex.
/home/davydden/spack/opt/spack/linux-ubuntu16-x86_64/gcc-5.4.0/trilinos-12.8.1-fwmxwfpiqrrolya5mboyv6jvbz6imq4s/include/AnasaziSolverUtils.hpp	655	err	V621 Consider inspecting the 'for' operator. It's possible that the loop will be executed incorrectly or won't be executed at all.
/home/davydden/spack/opt/spack/linux-ubuntu16-x86_64/gcc-5.4.0/trilinos-12.8.1-fwmxwfpiqrrolya5mboyv6jvbz6imq4s/include/AnasaziSolverUtils.hpp	671	err	V621 Consider inspecting the 'for' operator. It's possible that the loop will be executed incorrectly or won't be executed at all.
/home/davydden/spack/opt/spack/linux-ubuntu16-x86_64/gcc-5.4.0/trilinos-12.8.1-fwmxwfpiqrrolya5mboyv6jvbz6imq4s/include/AnasaziMatOrthoManager.hpp	425	err	V547 Expression is always false. Unsigned type value is never < 0.
/home/davydden/spack/opt/spack/linux-ubuntu16-x86_64/gcc-5.4.0/trilinos-12.8.1-fwmxwfpiqrrolya5mboyv6jvbz6imq4s/include/AnasaziMatOrthoManager.hpp	457	err	V621 Consider inspecting the 'for' operator. It's possible that the loop will be executed incorrectly or won't be executed at all.
/home/davydden/spack/opt/spack/linux-ubuntu16-x86_64/gcc-5.4.0/trilinos-12.8.1-fwmxwfpiqrrolya5mboyv6jvbz6imq4s/include/AnasaziSVQBOrthoManager.hpp	310	err	V621 Consider inspecting the 'for' operator. It's possible that the loop will be executed incorrectly or won't be executed at all.
/home/davydden/spack/opt/spack/linux-ubuntu16-x86_64/gcc-5.4.0/trilinos-12.8.1-fwmxwfpiqrrolya5mboyv6jvbz6imq4s/include/AnasaziSVQBOrthoManager.hpp	454	warn	V560 A part of conditional expression is always false: qr != xr.
/home/davydden/spack/opt/spack/linux-ubuntu16-x86_64/gcc-5.4.0/trilinos-12.8.1-fwmxwfpiqrrolya5mboyv6jvbz6imq4s/include/AnasaziBasicOrthoManager.hpp	335	err	V621 Consider inspecting the 'for' operator. It's possible that the loop will be executed incorrectly or won't be executed at all.
/home/davydden/spack/opt/spack/linux-ubuntu16-x86_64/gcc-5.4.0/trilinos-12.8.1-fwmxwfpiqrrolya5mboyv6jvbz6imq4s/include/AnasaziLOBPCGSolMgr.hpp	664	warn	V747 An odd expression inside parenthesis. It is possible that a function name is missing.
/home/davydden/spack/opt/spack/linux-ubuntu16-x86_64/gcc-5.4.0/trilinos-12.8.1-fwmxwfpiqrrolya5mboyv6jvbz6imq4s/include/Teuchos_CommandLineProcessor.hpp	464	warn	V730 Not all members of a class are initialized inside the constructor. Consider inspecting: opt_name, opt_name_false, documentation.

to do a proper analysis, you can get a one week trial license for Linux from PVS, see http://www.viva64.com/en/b/0441/ .
A quick usage example for deal.II is in this issue. In that thread there is also a script to create Github issue for each analysis, if you would like to cover them and track progress.

[mhoemmen]

I think the only one of these that may be spurious is "ScalarTraits < ScalarType >::isComplex is always false." That's a compile-time constant in a traits class, used inside a class (SerialDenseMatrix) templated on ScalarType. One legitimate way to program is to use those constants to dispatch at run time. In some cases, the compiler may eliminate that never-called code.

[mhoemmen]

@trilinos/teuchos @trilinos/teuchos

[github-actions]

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.

[github-actions]

This issue was closed due to inactivity for 395 days.