Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for poorly documented functions #93

Closed
b4yuan opened this issue Jun 21, 2023 · 1 comment
Closed

Add documentation for poorly documented functions #93

b4yuan opened this issue Jun 21, 2023 · 1 comment

Comments

@b4yuan
Copy link

b4yuan commented Jun 21, 2023

Functions trilogy_packet_parser_execute in src/packet_parser.c and main in example/trilogy_query.c are very large functions with little to no documentation, making them hard to maintain.

@matthewd
Copy link
Contributor

Thanks for the suggestion, but I think those functions are both fine in their current state. Line count is not a direct indicator of complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants