Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.3.3 breaks build #28

Closed
janvanuytrecht opened this issue Sep 11, 2017 · 5 comments
Closed

Release 2.3.3 breaks build #28

janvanuytrecht opened this issue Sep 11, 2017 · 5 comments
Assignees
Labels

Comments

@janvanuytrecht
Copy link

Moving the typings dependency from dev to peer forces people using the package to include the typings package to their dev dependency package list.

Maybe this is as intended, but then it should be included in the readme I guess.

@mikemwalsh
Copy link

Confirmed. 2.3.3 is coming down on NPM for me now on my build server (using ^2.0.0 in package.json) and the build is broken. Minor/build version releases should not cause breaking changes. I have locked myself at 2.3.2 for now.

@MarkPieszak
Copy link
Member

It seemed we needed it for another precious issue, do we need to put it back to where it was? @mikemwalsh @janvanuytrecht Apologies guys!

@janvanuytrecht
Copy link
Author

janvanuytrecht commented Sep 13, 2017 via email

@mikemwalsh
Copy link

@MarkPieszak I am actually not sure this specifically was my issue. I had to roll back to a previous version. I will try to figure out what broke it for me and report back

@MarkPieszak
Copy link
Member

MarkPieszak commented Sep 13, 2017

Should be fixed now via 2.3.4, just tested on a blank angular-cli project and no errors when building or installing :) @mikemwalsh @janvanuytrecht

Sorry about that! Thanks for reporting this one 👍

@MarkPieszak MarkPieszak self-assigned this Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants