-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.3.3 breaks build #28
Comments
Confirmed. 2.3.3 is coming down on NPM for me now on my build server (using ^2.0.0 in package.json) and the build is broken. Minor/build version releases should not cause breaking changes. I have locked myself at 2.3.2 for now. |
It seemed we needed it for another precious issue, do we need to put it back to where it was? @mikemwalsh @janvanuytrecht Apologies guys! |
No worries.
I would just note it in the readme file that consumers should also include the typings in their Dev dependencies. And add it as a dependency on the npm site
Mvg,
Jan.
… On 13 Sep 2017, at 18:54, Mark Pieszak ***@***.***> wrote:
It seemed we needed it for another precious issue, do we need to put it back to where it was? @mikemwalsh @janvanuytrecht Apologies guys!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@MarkPieszak I am actually not sure this specifically was my issue. I had to roll back to a previous version. I will try to figure out what broke it for me and report back |
Should be fixed now via Sorry about that! Thanks for reporting this one 👍 |
Moving the typings dependency from dev to peer forces people using the package to include the typings package to their dev dependency package list.
Maybe this is as intended, but then it should be included in the readme I guess.
The text was updated successfully, but these errors were encountered: