Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Material design 2 example #20

Closed
ardevik opened this issue Nov 13, 2016 · 14 comments
Closed

Add Material design 2 example #20

ardevik opened this issue Nov 13, 2016 · 14 comments

Comments

@ardevik
Copy link

ardevik commented Nov 13, 2016

I try to use your template, and change the ng2-bootstrap with the material2 but I always get an error. Can you add the sample for material2

@MarkPieszak
Copy link
Member

Sure, not a problem.
I wasn't sure whether to go bootstrap or material for the Starter, but I can showcase how to set that up. There's a few gotchas with Universal & Material.

@MarkPieszak
Copy link
Member

So it looks like Material2 doesn't work with Universal or Webworkers at the moment, they're still in Alpha so I'm not sure exactly when we'll be in sync, so we'll have to delay that Integration unfortunately!

Although if you shut off server-side rendering for now, you'll be able to use Material2.
You can just remove the asp-prerender tags in Views/Home/Index.cshtml to disable it.

https://github.com/MarkPieszak/aspnetcore-angular2-universal/blob/master/Views/Home/Index.cshtml#L5-L6

@mah1212
Copy link

mah1212 commented Nov 25, 2016

We are trying to use your template with Material2 as well. Waiting for the example app.

@MarkPieszak
Copy link
Member

Hey @mahbub-a-rob, I spoke with a few Material devs the other day and it's on their priority list especially for their 1.0 release but at this moment it doesn't work right out of the box. I believe there might be some very hacks ways to get Material to work when server rendering, but they would keep changing release to release. :(

For the time being, would it be fine to shut off server side rendering and use Material? That way you could at least get going with the App itself, while the Universal integration gets finalized for it.

@MarkPieszak
Copy link
Member

Waiting on angular/components#308

@mah1212
Copy link

mah1212 commented Dec 29, 2016

Hey, @MarkPieszak, yeah, sure, as we have no other option right now. In that case, I guess, it would be better to provide an example for the users on "How to use Material2 in this app" until we get the facility with server side rendering.

@MarkPieszak
Copy link
Member

Good idea, I'll add a section to the readme to point it out! @Mahbub-A-Rob

@MarkPieszak
Copy link
Member

Added the note! I'll close this out for now. I'll let you know when Material gets full Universal support 👍

@MarkPieszak
Copy link
Member

@Mahbub-A-Rob Here's a hack/workaround to get Material up and running with Universal in the meantime, if you still needed it: angular/components#308 (comment)

Putting it here in case others need it as well.

@mah1212
Copy link

mah1212 commented Feb 25, 2017

@MarkPieszak Thank you for the link. I will check it out.

@MarkPieszak
Copy link
Member

We're about to release ng4 in March sometime, so hopefully after that Material can make the necessary changes and will be able to work without any problems at all 👍

@mah1212
Copy link

mah1212 commented Feb 28, 2017

Eagerly waiting for ng4.

@ElderJames
Copy link

It seem that material 2.0.0 stable version would fully support the angular/platform-server

@odahcam
Copy link
Contributor

odahcam commented Dec 4, 2017

So what can be done now (with Ng 5 + NgMaterial 2 or 5), the external bug still exists? 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants