Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating Toolbar in Web Components #1420

Open
2 tasks done
davidtsilcock opened this issue Jun 13, 2023 · 12 comments
Open
2 tasks done

Floating Toolbar in Web Components #1420

davidtsilcock opened this issue Jun 13, 2023 · 12 comments
Assignees
Labels
5 5 story points contribution Development will be done by members outside the Modus team external-request Bugs and features reported by individuals from other teams in Trimble modus-approved Reviewed and approved by Modus new-component New component team-trimble-creator Team name: Nexus, Product names: Creator, RDK (Rapid Development Kit), Division: Trimble Technology

Comments

@davidtsilcock
Copy link

Prerequisites

Proposal

This is a ticket outlining the work to be done on the toolbar in the floating UI style that has been discussed with the modus team.

This development can be carried out by the Creator/Nexus team.

Original toolbar:
Modus doesn't currently have a toolbar in its library, however, it would look something like this in the current style.
Screenshot 2023-06-14 102701

Floating UI Navbar:
Screenshot 2023-06-14 102715

Trimble Creator Navbar:
Screenshot 2023-06-14 102304

The toolbar would like just be a standard modus button contained in a panel/wrapper of some sort.

We would like to develop this as a Modus web component, and then contribute it back to Modus.

Motivation and context

Floating UI is a critical part of a canvas-style application such as Trimble Creator, SketchUp, Maps, and more. This UI allows the user to focus more o the creative space rather than the encompassing UI.

What is the issue regarding ?

@trimble-oss/modus-web-components

Priority

Medium

What product/project are you using Modus Components for ?

Trimble Creator

What is your team/division name ?

Nexus

Are you willing to contribute ?

Yes

Are you using Modus Web Components in production ?

Not yet, this will be one of the first steps on our migration to web-components in Trimble Creator.

@msankaran0712 msankaran0712 added external-request Bugs and features reported by individuals from other teams in Trimble team-trimble-creator Team name: Nexus, Product names: Creator, RDK (Rapid Development Kit), Division: Trimble Technology labels Jun 14, 2023
@msankaran0712 msankaran0712 mentioned this issue Jun 23, 2023
2 tasks
@msankaran0712 msankaran0712 added contribution Development will be done by members outside the Modus team modus-approved Reviewed and approved by Modus labels Jun 23, 2023
@enowak1031 enowak1031 changed the title Floating UI: Toolbar Floating Toolbar in Web Components Jun 29, 2023
@msankaran0712
Copy link
Contributor

Moving this to backlog until Trimble creator team or someone is available to contribute

@msankaran0712 msankaran0712 added the new-component New component label Nov 2, 2023
@msankaran0712
Copy link
Contributor

Maha to add Figma and Styleguide references

@msankaran0712
Copy link
Contributor

msankaran0712 commented Nov 7, 2023

Maha to check with the Modus team about what is the status of Floating Toolbar, Navbar and Utility panel on Styleguide and figma

@sorina-ocheana
Copy link
Contributor

I'll be the one contributing to this component

@sorina-ocheana
Copy link
Contributor

chrome_Lfikz2GFSS

  • The red toolbar is opened by button no. 1 and it's placed on the left
  • The blue toolbar is opened by button no. 2 and it's placed on top
  • With green is a dropdown placed on top, opened by button no. 3

@sorina-ocheana
Copy link
Contributor

EmLU59y
Text button

@msankaran0712
Copy link
Contributor

@egunther39 Do you have any comments on the above use cases?

@msankaran0712
Copy link
Contributor

@sorina-ocheana Can you please explain the use case for text button? Why can't have a icon button instead?

@davidtsilcock
Copy link
Author

We could have an icon button, but I imagine there are a lot of use cases where text buttons would be needed in toolbars. Take Trimble Drawing for example:

Frame 100

I feel that it would be more productive for the component to allow any type of button to sit inside it, not just icon only buttons.

@msankaran0712
Copy link
Contributor

@enowak1031 @egunther39 any comments on the text buttons inside a Toolbar?

cc @davidtsilcock @sorina-ocheana

@egunther39
Copy link

@msankaran0712 @davidtsilcock @enowak1031 - I think this is a valid use case and I'm okay with this

@msankaran0712
Copy link
Contributor

@davidtsilcock we are good with having text buttons in Toolbar. PLease proceed with the developemnt

@sorina-ocheana sorina-ocheana mentioned this issue Dec 14, 2023
13 tasks
@cjwinsor cjwinsor self-assigned this Feb 13, 2024
@cjwinsor cjwinsor added the 5 5 story points label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 5 story points contribution Development will be done by members outside the Modus team external-request Bugs and features reported by individuals from other teams in Trimble modus-approved Reviewed and approved by Modus new-component New component team-trimble-creator Team name: Nexus, Product names: Creator, RDK (Rapid Development Kit), Division: Trimble Technology
Projects
Status: Refinement
Development

No branches or pull requests

5 participants