Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The put method is treating the timespan as ms. #1

Open
daniebker opened this issue Aug 18, 2020 · 0 comments · May be fixed by #2
Open

The put method is treating the timespan as ms. #1

daniebker opened this issue Aug 18, 2020 · 0 comments · May be fixed by #2

Comments

@daniebker
Copy link

I've been trying to cache something for 65 days but noticed that the cache has been expiring and the file removed. Date.now() returns milliseconds elapsed since Jan 1st 1970 00:00: 00 UTC. So the value passed to put is actually treated as MS, not seconds. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/now

Repro

  1. Put an Item in the cache with seconds param set to: 5616000
  2. Expected that the unix timestamp in the TTL is 1603391361815 (Oct 22, 65 days from Aug 18)
  3. Actual timestamp in the cache is 2 hours later.

I can fix it locally by multiplying my value by 1000 which gives me the unix timestamp I expect.
@daniebker daniebker linked a pull request Aug 18, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

convert seconds to ms daniebker/node-filesystem-cache
1 participant
@daniebker