Setting config.http.nio = true does nothing

[hydrogen18]

I'm using JRuby 9.1.9.0
When you add to trinidad.rb something like this

config.http = { nio: true }

The expectation is an NIO protocol handler is used. It is not.

In lib/trinidad/server.rb the method add_service_connector is defined and contains the following

if handler = options.delete(:protocol_handler) || options.delete(:protocol_handler_class_name)
  connector.protocol_handler_class_name = handler
end

Calling connector.protocol_handler_class_name = handler invokes a method on a Java class, so JRuby is emitting some magic interface here. What it invokes I don't know, but it doesn't do anything useful. I'm unsure if the underlying Java server even allows changing the protocol handler after it is created on the first line of this method

connector = Tomcat::Connector.new(options.delete(:protocol) || protocol)

Specifying the following in my trindad.rb works for me :

config.http = { protocol: "org.apache.coyote.http11.Http11NioProtocol" }

I think all the code around :nio option could just be removed for clarity and cleanliness of the project.