Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win32 Compatibility, Round 2 #3

Closed
sanko opened this issue Jul 13, 2011 · 1 comment
Closed

Win32 Compatibility, Round 2 #3

sanko opened this issue Jul 13, 2011 · 1 comment

Comments

@sanko
Copy link

sanko commented Jul 13, 2011

Hi!

All changes made work so far. ...that's the good news. The bad news is Windows is still fighting against you.

I won't go into Perl on Windows' fork, exec, and signal emulation but suffice it to say it doesn't work correctly; Right now, your tests leave zombie redis-server processes behind and/or hang. In most of your tests, issuing a shutdown command to redis before calling $server->stop is enough but that wouldn't work for t/transactions.t where you lose the connection before exit. ...and even with that change, Windows bungles kill SIGTERM, $self->{pid}; and the tests are marked failures. kill 0, $self->{pid};, despite being incorrect, works except in t/transactions.t where it still just hangs.

And, as written, timeouts don't work on Windows so you could skip these as you do on Solaris.

@trinitum
Copy link
Member

Thank you for your help! I think this time I got it right, I'm sending shutdown instead of killing redis on Windows, and skipping timeout too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants