Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iceberg connector bug not returning external location with show create table #10459

Conversation

austenLacy
Copy link
Member

@austenLacy austenLacy commented Jan 4, 2022

Fixes: #9732

When doing a show create table some_table for an iceberg table, Trino does not return the location property if one is defined.

trino > create table test_iceberg.schema1.some_table (c1 VARCHAR, c2 VARCHAR)
with (
    format = 'PARQUET',
    partitioning = ARRAY['c1'],
    location = 'gs://some/path'
);

...

trino> show create table test_iceberg.schema1.some_table;

CREATE TABLE test_iceberg.schema1.some_table (
   c1 varchar,
   c2 varchar
)
WITH (
   format = 'PARQUET',
   partitioning = ARRAY['c1']
)

before the fix

before

after the fix

after

@cla-bot cla-bot bot added the cla-signed label Jan 4, 2022
@austenLacy austenLacy force-pushed the austenlacy/fix-iceberg-connector-show-create-table-bug branch from 36137e0 to fba47a3 Compare January 4, 2022 16:25
Copy link
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please check related build failures?

@austenLacy austenLacy force-pushed the austenlacy/fix-iceberg-connector-show-create-table-bug branch 2 times, most recently from b62505b to 8678f86 Compare January 6, 2022 17:01
@austenLacy austenLacy force-pushed the austenlacy/fix-iceberg-connector-show-create-table-bug branch from 8678f86 to 14a9346 Compare January 6, 2022 18:01
@austenLacy
Copy link
Member Author

@findepi I pushed fixes for the unit and integration tests. There are some other failures with the recent CI run, but they look unrelated to these changes.

@findepi
Copy link
Member

findepi commented Jan 10, 2022

i've retriggered the CI

@findepi findepi merged commit 995d5b2 into trinodb:master Jan 10, 2022
@findepi findepi mentioned this pull request Jan 10, 2022
@austenLacy austenLacy deleted the austenlacy/fix-iceberg-connector-show-create-table-bug branch January 10, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Location field not acknowledged when creating iceberg tables
2 participants