Remove deprecated API from ConnectorPageSourceProvider #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokosing
reviewed
Jul 8, 2019
| @@ -26,19 +26,6 @@ default ConnectorPageSource createPageSource( | |||
| ConnectorSplit split, | |||
There was a problem hiding this comment.
a typo in commit msg and PR title
| /** | ||
| * @param columns columns that should show up in the output page, in this order | ||
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
IIRC we had one issue where TupleDomain was common for a table scan and we are copying it for all splits so we capture it in TableHandle and pass it to the worker so the size of split can be reduced
Praveen2112
changed the title
Praveen2112
force-pushed
the
remove_depricated_pagesource_api
branch
from
a7ac513
to
4de56b0
Compare
|
@kokosing Thanks for pointing it out. Have updated it |
kokosing
approved these changes
Jul 8, 2019
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.